Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release causes "Illegal instruction" error on Windows #24

Closed
pdesaulniers opened this issue Aug 13, 2019 · 4 comments
Closed

Latest release causes "Illegal instruction" error on Windows #24

pdesaulniers opened this issue Aug 13, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@pdesaulniers
Copy link
Contributor

If I run the blob demo on Windows, using the latest v2.0a3 release, I get an Illegal instruction error.

I also get this error in the latest git version, built using VS Community 2017.

I'm running Windows 10, 64-bit.

The v2.0a2 release does not have this issue.

@pdesaulniers
Copy link
Contributor Author

pdesaulniers commented Aug 13, 2019

Fixed by removing /arch:AVX from the SConstruct file.

I suppose this flag should be removed, for better hardware compatibility.

Is there a feature in TOVE that requires AVX support?

@poke1024 poke1024 added the bug Something isn't working label Aug 14, 2019
@poke1024
Copy link
Owner

@pdesaulniers No, AVX just makes some things considerably faster (esp. the dithering stuff in fact, where lots of pixel data is moved around). However, I haven't benchmarked this, so removing /arch:AVX is a good idea. I'll take care of it.

@pdesaulniers
Copy link
Contributor Author

pdesaulniers commented Aug 15, 2019

Actually, I'm getting the same error (SIGILL) on my low-end Linux laptop.

In this case, the fix was to remove the -mf16c flag, and to tweak common.h so that store_gpu_float uses the non-instrinsic fp16 conversion.

@poke1024
Copy link
Owner

Ok, thanks a lot for debugging this. I'll change the defaults to not use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants