Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shared] Config and Genesis refactoring improvement: ValidateConfig has to work with mocks and real implementation #294

Closed
7 tasks
deblasis opened this issue Oct 6, 2022 · 1 comment
Labels
code health Nice to have code improvement core Core infrastructure - protocol related

Comments

@deblasis
Copy link
Contributor

deblasis commented Oct 6, 2022

Objective

Keep track and address areas of improvement. Specifically, in this issue we aim at addressing the comments below

Related PR #235

Origin Document

Goals

  • Improve code quality

Deliverable

  • Refactor the code so that there's no ambiguity

Non-goals / Non-deliverables

  • Changes in logic

General issue deliverables

  • Update the appropriate CHANGELOG
  • Update any relevant READMEs (local and/or global)
  • Update any relevant global documentation & references
  • If applicable, update the source code tree explanation
  • If applicable, add or update a state, sequence or flowchart diagram using mermaid

[Optional] Testing Methodology

  • _REPLACE_ME: Make sure to update the testing methodology appropriately_
  • Task specific tests: make ...
  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @deblasis
Co-Owners: @Olshansk

@deblasis
Copy link
Contributor Author

We are using interfaces now, this can be closed

Repository owner moved this from Backlog to Done in V1 Dashboard Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Nice to have code improvement core Core infrastructure - protocol related
Projects
Status: Done
Development

No branches or pull requests

2 participants