Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more helpful output during Dataset and Benchmark object creation #150

Open
Andrewq11 opened this issue Jul 22, 2024 · 0 comments
Open
Labels
enhancement New feature or request
Milestone

Comments

@Andrewq11
Copy link
Contributor

Context

There are certain preparation and validation steps which occur when Dataset and Benchmark objects are created. These steps can take a relatively long time depending on the underlying data (e.g. in the worst case, minutes).

While these computations are running, more logging is needed to help the user understand that certain steps are underway. Otherwise, under certain circumstances, it could be appear that their machine is hanging.

Description

I see a few options for how we could tackle this:

  • We could identify the longer running validation steps (e.g. split field validator in BenchmarkSpecification) and add logging statements at the start of each validator letting the user know this could take some time
  • We could add a single logging statement at the beginning of the entire validation process saying this could take some time (e.g. less specific than the first option)
  • We could investigate how to add a loading indicator as we did with the upload/download operations for artifacts (my preference)

Acceptance Criteria

  • Additional logging/output is included during Dataset or Benchmark object creation which consistently lets the user know that work is being done and their machine is not hanging
@Andrewq11 Andrewq11 added the enhancement New feature or request label Jul 22, 2024
@cwognum cwognum added this to the XL Benchmarks milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants