-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Descend XCM origin instead of clearing it where possible #109
Descend XCM origin instead of clearing it where possible #109
Conversation
XCM programs that want to ensure that the following XCM instructions cannot command the authority of the Original Origin (such as asset transfer programs) should consider, where possible, using DescendOrigin into a demoted, safer origin rather than ClearOrigin which clears the origin completely. Signed-off-by: Adrian Catangiu <adrian@parity.io>
cc @albertov19 @xlc |
@acatangiu - We still need to push a standard for remote origin calculation among chains. There were a lot of discussions back in the day, and a standard was set, but the standard has not been implemented in either the Relay Chain or System Chains. |
I'm not aware of this. I think this was "before my time", can you help link some issues/discussions/etc? |
Original PR and Discussions -> paritytech/polkadot#6662 Also saw this discussion -> polkadot-fellows/runtimes#67 |
I think that's orthogonal to this RFC - the mechanism proposed here works regardless of the remote origin calculation mechanism. But looking at the state of the ecosystem, seems we are going towards alignment, although many parachains don't seem to care about this conversion and have no hashed description configured: (non-exhaustive list)
|
Agreed - but the standard would solidify if system chains and the relay chain would implement it. Also, those chains filter |
But they already do implement it. All System Chains (Relay included) on both Kusama and Polkadot include a
I checked and indeed the XCM send filter ( Either way, like I said before this is orthogonal to this RFC, no? |
Agreed - I just saw |
|
||
## Unresolved Questions | ||
|
||
How to achieve this for all workflows, not just point-to-point XCM programs with no intermediary hops? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how to do it:
Closing this in favor of more extensible #122 |
XCM programs that want to ensure that the following XCM instructions cannot command the authority of the Original Origin (such as asset transfer programs) should consider, where possible, using DescendOrigin into a demoted, safer origin rather than ClearOrigin which clears the origin completely.