Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Polkadot Sdk in the release #157

Closed
bkchr opened this issue Jan 23, 2024 · 7 comments
Closed

Mention Polkadot Sdk in the release #157

bkchr opened this issue Jan 23, 2024 · 7 comments

Comments

@bkchr
Copy link
Contributor

bkchr commented Jan 23, 2024

We should mention the Polkadot Sdk versions in the release notes. This will make it easier for downstream users to find out about the changes that are pulled in through the polkadot sdk.

@IkerAlus
Copy link

Ideally for users and service providers, runtime changes (f.e., a certain call is removed from a pallet) should have direct visibility in the runtime release changelog. This may be as simple as copy-pasting the relevant changes contained in the corresponding Polkadot-SDK release changelog and most likely can be automated per release.

@bkchr
Copy link
Contributor Author

bkchr commented Jan 25, 2024

If there is a link to the Sdk release notes, I don't see any reason to duplicate this information.

@IkerAlus
Copy link

If there is a link to the Sdk release notes, I don't see any reason to duplicate this information.

This will suffice if every runtime release has a 1-to-1 correspondence with the changes in a specific Polkadot-SDK release. Will this be the case?

For example, doing a quick search I see PR1226, about removing the transfer call, in the changelogs of both Polkadot-SDK release 1.2 and 1.6. This would be confusing if there was only a link to the Polkadot-SDK notes.

@bkchr
Copy link
Contributor Author

bkchr commented Jan 26, 2024

This will suffice if every runtime release has a 1-to-1 correspondence with the changes in a specific Polkadot-SDK release. Will this be the case?

Yes. I mean if we include these changes in a release here, than you will also see them downstream.

For example, doing a quick search I see PR1226, about removing the transfer call, in the changelogs of both Polkadot-SDK release 1.2 and 1.6. This would be confusing if there was only a link to the Polkadot-SDK notes.

This is not really related to this discussion here? If this is the case that we included things multiple times, it needs to be fixed on the SDK side and not here.

@IkerAlus
Copy link

This is not really related to this discussion here? If this is the case that we included things multiple times, it needs to be fixed on the SDK side and not here.

That is why I suggested adding specific changes to the runtime releases changelogs in my first comment. My assumption was that the Fellowship can't presuppose that SDK release changelogs are always unequivocal. But indeed, the better solution should happen at SDK side.

@bkchr
Copy link
Contributor Author

bkchr commented Jan 28, 2024

Fixing broken release changelogs should not be done downstream and instead where they are created.

@bkchr
Copy link
Contributor Author

bkchr commented Mar 11, 2024

@bkchr bkchr closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants