Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using RuntimeGenesisConfig instead of directly constructing json for the preset genesis patch #431

Open
seadanda opened this issue Aug 13, 2024 · 2 comments · May be fixed by #451
Open

Consider using RuntimeGenesisConfig instead of directly constructing json for the preset genesis patch #431

seadanda opened this issue Aug 13, 2024 · 2 comments · May be fixed by #451

Comments

@seadanda
Copy link
Contributor 

          Not sure why we not use the `GenesisConfig` type from the runtime here.

Originally posted by @bkchr in #410 (comment)

With further conversation following.
@seadanda seadanda mentioned this issue Aug 13, 2024
Merged
2 tasks
@dharjeezy
Copy link
Contributor

@seadanda thinking of working on this but i want to know if you are already working on it?

@seadanda
Copy link
Contributor Author

Hi @dharjeezy, no I'm not working on it. There was some difference of opinion in the previous discussion so we kept it out of the PR

@dharjeezy dharjeezy linked a pull request Sep 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use RuntimeGenesisConfig in genesis config presets dharjeezy/runtimes
2 participants
@dharjeezy @seadanda