Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Struct JSON maps overrides (when on testnets) #621

Closed
1 of 2 tasks
jacogr opened this issue Jan 23, 2019 · 1 comment · Fixed by #918
Closed
1 of 2 tasks

Remove Struct JSON maps overrides (when on testnets) #621

jacogr opened this issue Jan 23, 2019 · 1 comment · Fixed by #918
Assignees

Comments

@jacogr
Copy link
Member

jacogr commented Jan 23, 2019

(Raised in #618)

This can be done when the camelCase changes in paritytech/substrate#1507 has been rolled out to the testnets. It is available on substrate master and the code caters for both cases, so no urgent rush -

The API gracefully handles both old and new versions, so this is just a cleanup.

https://github.com/polkadot-js/api/blob/master/packages/types/src/Health.ts#L9
https://github.com/polkadot-js/api/blob/master/packages/types/src/PeerInfo.ts#L12
https://github.com/polkadot-js/api/blob/master/packages/types/src/RuntimeVersion.ts#L81

@jacogr jacogr added this to the As-and-when milestone Jan 23, 2019
@jacogr jacogr changed the title Remove Struct JSON maps overrides Remove Struct JSON maps overrides (when on testnets) Jan 23, 2019
@jacogr jacogr self-assigned this May 16, 2019
@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants