Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of the contracts_instantiate RPC #5338

Open
athei opened this issue May 21, 2021 · 5 comments
Open

Make use of the contracts_instantiate RPC #5338

athei opened this issue May 21, 2021 · 5 comments

Comments

@athei
Copy link

athei commented May 21, 2021

We should make use of the somewhat recently added contracts_instantiate ( paritytech/substrate#8451 ) RPC in order to help users picking an endowment and gas_limit values when instantiating a new contract. Any error returned (or the revert flag) should be displayed to the user.

@cmichi
Copy link
Contributor

cmichi commented Jun 20, 2021

I'm just copy/pasting this over from #5629 in favor of closing that issue.

A thing to keep in mind when making use of the contracts_instantiate RPC is to execute a dry-run RPC of the contract constructor before deployment of contract:

In paritytech/ink#821 we found that debug messages which are printed in contract constructors do not appear on the console. Debug messages in functions of an instantiated contract appear though. This is because

Debugging is not enabled during on-chain execution. Only during RPC calls.

In order to support debug messages in constructors the UI should execute a RPC dry-run of the constructor before deployment of a contract.

@cmichi
Copy link
Contributor

cmichi commented Oct 31, 2021

@jacogr We're currently planning the roadmap for Canvas and just want to bring up that this issue is still important for us :-).

@HCastano
Copy link

@statictype FYI, this is one of the issues we talked about earlier today

@jacogr
Copy link
Member

jacogr commented Oct 31, 2021

I am acutely aware of it, but have only X hours in a day despite best efforts.

@HCastano
Copy link

HCastano commented Nov 1, 2021

Whenever you have time, don't worry about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants