-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for non-payable
ink!
constructors
#6645
Comments
Needs an ABI update (V3) where the flags are passed through on the constructors. Currently V2 of the ABI defines - ContractConstructorSpecV2: {
label: 'Text',
selector: 'ContractSelector',
args: 'Vec<ContractMessageParamSpecV2>',
docs: 'Vec<Text>'
}, (messages are slightly extended form the above with payable, mutating and identifier fields). Marked as |
The metadata will be bumped with use-ink/ink#1100 |
@HCastano Brilliant, thank you! Will make an issue linking though to that PR to get in support on the API layer. |
The value seems only passed-through when the constructor is payable, aka
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query. |
Right now the UI assumes that all
ink!
constructors need avalue
(renamed fromendowment
in paritytech/substrate#10082). However, with use-ink/ink#1065 this is no longer the case.The UI should only display the
value
field in case the constructor is marked aspayable
. This behaviour is already implemented by the UI forink!
messages
.Reference of the screen where a
value/endowment
is asked for (Developer > Contracts > Upload and Deploy Code):The text was updated successfully, but these errors were encountered: