Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR not quite 100% #793

Closed
jacogr opened this issue Mar 7, 2019 · 8 comments
Closed

HMR not quite 100% #793

jacogr opened this issue Mar 7, 2019 · 8 comments
Labels

Comments

@jacogr
Copy link
Member

jacogr commented Mar 7, 2019

polkadot substrate portal 2019-03-07 12-26-19

Additionally on changes, it detects, does something (loads the changes) and you end up with a blank page. (Got this by editing the staking app). So we are in a slightly worse position since we now need to reload after the auto load.

@Stefie
Copy link
Contributor

Stefie commented Mar 7, 2019

on changes, it detects, does something (loads the changes) and you end up with a blank page.

hmm... I can't reproduce that. It's working fine on my machine with Alexander. Did you make a fresh install of the node_modules?

@Stefie
Copy link
Contributor

Stefie commented Mar 7, 2019

(I"m also getting the console.warning, though)

@jacogr
Copy link
Member Author

jacogr commented Mar 7, 2019

It works intermittently... so the last couple it has been working. No idea how to reproduce atm. :(

@rossbulat
Copy link
Contributor

I also got the hot loader patch warning. It is being discussed here too, not yet resolved.

@Stefie
Copy link
Contributor

Stefie commented Mar 7, 2019

I'm getting slightly annoyed by this warning... tried all suggested solutions to get rid of it but none of them worked. https://github.com/gaearon/react-hot-loader#react--dom

@jacogr
Copy link
Member Author

jacogr commented Mar 7, 2019

Annoying as it is, it is ok - as long as the rest of the stuff is stable...

@Stefie
Copy link
Contributor

Stefie commented Mar 7, 2019

Yeah... so I‘d close this issue for now if none of you two had any issues with HMR tody anymore. I‘ve been working with it today and didn‘t experience any flaws

@Stefie Stefie closed this as completed Mar 7, 2019
@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants