Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The API is not view controller friendly #1

Open
andreaperizzato opened this issue Dec 21, 2015 · 1 comment
Open

The API is not view controller friendly #1

andreaperizzato opened this issue Dec 21, 2015 · 1 comment
Assignees

Comments

@andreaperizzato
Copy link

Hi,
i'm using pollfish in one of my apps and and creating this issue because the API is not very view-controller friendly. In my 2cents opinion, developers should be able to present the survey, if available, from any view controller with a simple method, such as:

Pollfish.showFromViewController(viewController: UIViewController) throws

which may throw when the survey is not available.
Moreover, the red 'pollfish' badge should be optional and you should allow developers to choose whether they want that badge or simply present the survey in a more iOS friendly way. I know that it is possible to call Pollfish.initWithPosition(...) and then hide(), but this is very nice because the survey will stick to the current view controller.
Last thing: if the current view controller is smaller than the screen (like an alert dialog), the survey will be smaller as well.

Hope it helps.
/Andrea

@kaspanvo kaspanvo self-assigned this Dec 22, 2015
@kaspanvo
Copy link
Contributor

Hello Andrea

Thank you for your report.

Pollfish at the moment works by placing an overlay view (when you call init) on the current view controller by traversing view hierarchy. Having that said it is not possible to have Pollfish overlay on multiple view controllers. However we will look into this in future development milestones.

Kind Regards

Andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants