Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use value equatable types #816

Open
bash opened this issue Jan 21, 2025 · 0 comments
Open

Use value equatable types #816

bash opened this issue Jan 21, 2025 · 0 comments
Labels
area: DiscriminatedUnion Issues for Funcky.DiscriminateUnion enhancement New feature or request

Comments

@bash
Copy link
Member

bash commented Jan 21, 2025

The cookbook recommends that source generators should pass along value equatable values so that the generator can short-circuit as soon as possible.

Our model (DiscriminatedUnion) currently includes lists without value equality and syntax nodes.
This prevents us from splitting the Emit function in two which would allow short-circuiting at that step.

@bash bash added area: DiscriminatedUnion Issues for Funcky.DiscriminateUnion enhancement New feature or request labels Jan 21, 2025
@bash bash changed the title Use value equatable types in Use value equatable types Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: DiscriminatedUnion Issues for Funcky.DiscriminateUnion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant