We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1AttributesTx
In #148, AdaptCosmosTxsToEthTxs was altered to return an error if deposit tx bytes fail to unmarshal as an ethtypes.Transaction.
AdaptCosmosTxsToEthTxs
ethtypes.Transaction
We should follow up with a specific check that an L1AttributesTx exists, and this check should apply on each adapter (eth->cosmos, cosmos->eth).
The text was updated successfully, but these errors were encountered:
Each adapter currently errors if there are no deposit txs:
(PayloadTxToCosmosTx)
monomer/adapters.go
Lines 38 to 40 in bd24e9a
(CosmosTxsToEthTxs)
Lines 107 to 109 in bd24e9a
But these checks implicitly assume that any collection of deposit txs will have an L1AttributesTx at the first position.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
In #148,
AdaptCosmosTxsToEthTxs
was altered to return an error if deposit tx bytes fail to unmarshal as anethtypes.Transaction
.We should follow up with a specific check that an
L1AttributesTx
exists, and this check should apply on each adapter (eth->cosmos, cosmos->eth).The text was updated successfully, but these errors were encountered: