We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WaitL1
WaitL2
It is preferable to have receivers, rather than fields that are set when the struct is built.
monomer/e2e/stack.go
Lines 294 to 299 in 6e976af
If I'm missing the reasoning, please correct me @NiloCK.
The text was updated successfully, but these errors were encountered:
On first write, they were separate but identical functions, which I combined as a de-duplication.
I'm fine either way, but it's a trade of indirection vs duplication with probably not a lot of gain in either direction.
indirection
duplication
Sorry, something went wrong.
The best way to go is probably to have a single function in stack_test.go
stack_test.go
func wait(client BlockByNumberInterface, numBlocks uint64) error { // implementation ... }
NiloCK
No branches or pull requests
It is preferable to have receivers, rather than fields that are set when the struct is built.
monomer/e2e/stack.go
Lines 294 to 299 in 6e976af
If I'm missing the reasoning, please correct me @NiloCK.
The text was updated successfully, but these errors were encountered: