Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Wildcards or 'All Tables' specification when adding Data Sources #449

Open
hennlo opened this issue Jun 7, 2023 · 4 comments
Open
Assignees
Labels
A-db Area: DB A-ui Area: UI C-enhancement Category: An issue proposing an enhancement E-easy

Comments

@hennlo
Copy link
Member

hennlo commented Jun 7, 2023

Affected Areas

DB, UI

Feature Description

When adding new Data Sources we currently only have the option to add tables, views by explicitly adding them name by name.

However, for larger projects this is impractical and tedious.
Instead allow adding multiple tables by creating a FLAG to add all tables
or allow wildcard specification using an asterix * to add all tables this user has access to for each schema.

This could also allow "blacklisting" some tables that should explicitly not be added.

Use Case(s)

This is related to Bug: #447
Intuitively it should work to add multiple tables at once , without specifying them one by one.

Possible Solutions

Extend SQL Syntax for system management to allow wildcards instead of specifying table by table.
Add possibility in UI to retrieve multiple tables at once. via wildcard or FLAG

Possible Alternatives

Add Data Sources only as connection objects and then in a separate step, create virtual/remote entities referencing to a source table via that connection.

That decouples the source creation from the virtual table creation.

This would also simplify "refreshing" definitions of existing data sources without really recreating them.

@hennlo hennlo added C-enhancement Category: An issue proposing an enhancement A-ui Area: UI A-db Area: DB E-easy labels Jun 7, 2023
@EslamAsHhraf
Copy link

@hennlo is the expected result is to prevent user to input * right?

@hennlo
Copy link
Member Author

hennlo commented Mar 1, 2024

@EslamAsHhraf No actually what you're describing is another issue: #447 that shall prevent any * from beeing rendered and executed because it currently breaks the schema.

This is issue is the successor to the first issue if you will so.
Becaase at the end I want to add different tables all at once without having to specify each one individually.
This issue is a little bit more advanced compared to the first one, because you need to add functionality to read the schema, detect all possibilities and subsequently add them to Polypheny.

But again if you want to work on prohibitting users to input * #447 is the issue for you.

@QamarSayyad33
Copy link

QamarSayyad33 commented Mar 11, 2024

Hi!
can u assign me this issue and issue #447 and I believe i can solve them as they appear related .

@AshishKothariii
Copy link

AshishKothariii commented Mar 23, 2024

Hii so we need to implement a feature in which if we add xyz* all the tables startung with xyz must be added here do we need to change only ui or the backend logic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Area: DB A-ui Area: UI C-enhancement Category: An issue proposing an enhancement E-easy
Projects
None yet
Development

No branches or pull requests

4 participants