Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support JDK 17 (or earlier with new cases) in CI #89

Closed
dours opened this issue Jan 23, 2022 · 2 comments
Closed

support JDK 17 (or earlier with new cases) in CI #89

dours opened this issue Jan 23, 2022 · 2 comments
Assignees
@PetrB09

Comments

@dours
Copy link
Collaborator

dours commented Jan 23, 2022 •
edited
Loading

https://github.com/polystat/py2eo/tree/tryGrammarByRobEin fails to build in CI, because it uses JDK11 to run maven and 17 to build the project. This is configured with the help of maven toolchain plugin, which needs a config file in ~/.m2 directory. How do we reproduce this in CI?

Tests pass locally on my computer.
@dours
Copy link
Collaborator Author

dours commented Jan 26, 2022

success with a hack, see #94

@dours
Copy link
Collaborator Author

dours commented Feb 7, 2022

Seems that @PetrB09 is happy with the hack, so I hereby proclaim the issue closed.

@dours dours closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PetrB09 PetrB09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dours @PetrB09