Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pallet-token-gateway benchmarks #351

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MrishoLukamba
Copy link
Contributor

closes #347

@seunlanlege
Copy link
Member

Ok stopped reviewing because this pr doesn't seem ready yet. Also, try to revert your format changes to the unrelated files with

git checkout main -- ./path/to/file

evm/lib/forge-std Outdated Show resolved Hide resolved
@MrishoLukamba
Copy link
Contributor Author

everything is working fine, except 2 benches, update and teleport, due to they require setting user balance on asset and native, which turns out to be kinda annoying on setting the balances, as genesis setting doesnt work and manuall setting too.

But am on it

Ok(())
}

impl_benchmark_test_suite!(Pallet, crate::mock::new_test_ex(), crate::mock::Test);
Copy link
Member

@Wizdave97 Wizdave97 Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just have the benchmarks so we don't need this mock implementation, it's too much code, we already have unit tests for the pallet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just generate the weight and delete the whole mock code?

@MrishoLukamba
Copy link
Contributor Author

@Wizdave97 done

evm/lib/forge-std Outdated Show resolved Hide resolved
Comment on lines 756 to 757
TokenGateway: pallet_token_gateway = 64,
HyperBridge: pallet_hyperbridge = 65,
Copy link
Member

@seunlanlege seunlanlege Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets revert, hyperbridge doesn't use pallet-token-gateway. The benchmarks are for downstream crates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

evm/lib/forge-std Outdated Show resolved Hide resolved
@seunlanlege seunlanlege changed the title feat(benchmarks) mock runtime config pallet-token-gateway benchmarks Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark pallet-token-gateway
3 participants