-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pallet-token-gateway
benchmarks
#351
base: main
Are you sure you want to change the base?
Conversation
Ok stopped reviewing because this pr doesn't seem ready yet. Also, try to revert your format changes to the unrelated files with
|
everything is working fine, except 2 benches, update and teleport, due to they require setting user balance on asset and native, which turns out to be kinda annoying on setting the balances, as genesis setting doesnt work and manuall setting too. But am on it |
Ok(()) | ||
} | ||
|
||
impl_benchmark_test_suite!(Pallet, crate::mock::new_test_ex(), crate::mock::Test); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just have the benchmarks so we don't need this mock implementation, it's too much code, we already have unit tests for the pallet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So just generate the weight and delete the whole mock code?
1e1431f
to
dbd3668
Compare
@Wizdave97 done |
dbd3668
to
8a7868b
Compare
TokenGateway: pallet_token_gateway = 64, | ||
HyperBridge: pallet_hyperbridge = 65, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets revert, hyperbridge doesn't use pallet-token-gateway. The benchmarks are for downstream crates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
pallet-token-gateway
benchmarks
closes #347