-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs manifest 0.1.0 #1735
Docs manifest 0.1.0 #1735
Conversation
packages/js/manifests/polywrap/src/formats/polywrap/migrators/0.3.0_to_0.4.0.ts
Show resolved
Hide resolved
I think the way you handled the docs examples is great. The execution of the examples can use same backend as An alternative would be to only put the metadata in the docs manifest and ask users to provide a link to their workflow file, but I think the UX is better the way you've done it. |
One thought - I think users should also be able to reference assets stored in the That kind of feature could come in a future PR |
This was actually the original idea!
This is not a bad idea at all. I'll see that we have something like this added. |
…pileks/feat/cli-docs-init-command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the "pages" entry in the manifest, to help simplify this new feature. Let's only keep the features we need for initial MVP of wrapscan.
To me this is:
- description
- logo
- repository
- website
- examples
packages/js/manifests/polywrap/src/formats/polywrap.app/validate.ts
Outdated
Show resolved
Hide resolved
I believe the correct fields for the Wrapscan MVP are:
We don't need the Examples field actually, as it's not part of the MVP. Nevertheless, I'd keep it as the sturcture seems good enough, and we'll be able to add examples much quicker if we just keep it. |
…pileks/feat/cli-docs-init-command
packages/js/manifests/polywrap/src/formats/polywrap.docs/0.1.0.ts
Outdated
Show resolved
Hide resolved
packages/js/manifests/polywrap/src/formats/polywrap/migrators/0.3.0_to_0.4.0.ts
Show resolved
Hide resolved
packages/js/manifests/polywrap/src/formats/polywrap/migrators/0.3.0_to_0.4.0.ts
Show resolved
Hide resolved
"uri": { | ||
"description": "URI of the wrap being invoked.", | ||
"type": "string", | ||
"tsType": "any" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? Don't we want this to be typed a "string"?
This PR introduces the Documentation Manifest, an extension manifest for the WASM/Interface project manifests.
An example documentation manifest:
I have decided against merging workflow jobs and doc examples at this time for the following reasons:
jobName
field to the workflow might work. Thoughts? (Still doesn't answer other points)step.description
in Workflows themselves, it would be a Docs addition to a manifest that doesn't belong to DocsIf
polywrap.docs.yaml
is present and mentioned inexts
of the Project Manifest,polywrap build
outputs all files related to documentation inside adocs
directory within the build output dir.This directory can then be consumed by
wrap-docs
, as is described in the following PR:polywrap/wrap-docs#8