Feat: update typescript/app template to latest bindings #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dOrgJelli
requested review from
krisbitney,
nerfZael,
Niraj-Kamdar and
cbrzn
as code owners
dOrgJelli
changed the title
| @@ -0,0 +1,15 @@ | |||
| import { BaseEthereum } from "./wrap"; | |||
There was a problem hiding this comment.
This would go in npm sdk
|
|
||
| const client = new PolywrapClient(); | ||
| import { Ethereum } from "./ethereum"; | ||
| import { Logger } from "./logger"; |
There was a problem hiding this comment.
This would be npm wrap sdk
dOrgJelli
commented
Aug 18, 2023
|
|
||
| import { CoreClient, PolywrapClient } from "@polywrap/client-js"; | ||
|
|
||
| export class Ethereum extends BaseEthereum { |
There was a problem hiding this comment.
As an app developer, it feels weird that I have to do this every time. I would imagine that the code below would be the "sane defaults", and if I wanted to change it I could do something like:
import { Ethereum as DefaultEthereum } from "./wrap"
class Ethereum extends DefaultEthereum {
protected _getDefaultClient(): CoreClient {
// TODO: create your own custom client
}
}
dOrgJelli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.