Add embed option to polywrap codegen
#1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dOrgJelli
reviewed
Sep 12, 2023
|
Not sure why CI is not green though, need to get that fixed. |
namesty
reviewed
Sep 12, 2023
cbrzn
reviewed
Sep 12, 2023
it seems that the rebuild of the wraps is broken due to a wrong path (weird, right?) I am debugging that in #1890 |
This is a great point. In the future, if this feature becomes more important, we can build it out differently. For example, we could generate bindings for one embedded wrap at a time. |
dOrgJelli
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--embedoption topolywrap codegen. When the option is specified, code for embedded wraps will be generated.See Rust implementation: polywrap/wrap-abi-bindgen#107
Closes #1703