-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Post origin build artifact #1046
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o into feat/remove-schema-file
…aphql in imported redirects
…anifest and import_redirects
… start making green client tests
… to WrapInfoManifest
cbrzn
added
pr: needs review
package: cli
package: client-js
pr: needs changes
and removed
pr: needs review
labels
Aug 16, 2022
dOrgJelli
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: This PR is being blocked by #1073
Post origin build artifact
Objective
Removal of schema.graphql in wrappers (wasm, plugins) & interfaces built artifact
Breaking changes
This introduces breaking changes that makes old wrappers not compatible with the new ones built with this new artifact. The reason is that currently, when a wrapper is imported, it tries to resolve a
schema.graphql
which is a string that needs to be converted to ABI.Plugins will have
wrap.info
(encoded w/msgpack) inside ofbuild
folder andwrap.info.ts
inside of thewrap
folder. Also, thegetManifest
method will be implemented inPluginWrapper
, allowing us to access to this manifestPolywrap (WASM & Interface), plugins, and app manifest have been updated to version
2.0
, being the main change in the attributeimport_redirects
, in order to supportinfo
instead ofschema
, allowing developers to point towrap.info
insteaf of theschema.graphql
Previously, we had the type
PluginPackageManifest
for plugins manifestsThis has been changed to:
Other important changes
schema.ts
has been removed from app codegenschema/composer
package doesn't output the schema anymore, but instead, only the ABIHotfixes
Because of the circular dependency in our monorepo, a few hacks needed to be done in order to have a functional build process of the libraries:
wrap-man
with new structure inside of every plugin and update the files to point to this manually generated folderbuild-man
for interfaces so they have thewrap.info
filehack.md of this description: https://hackmd.io/@cbrzn/Bki01E32q