-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Remove ABI from schema package #1073
Conversation
If I understand things correctly the change of null to undefined is an improvement of the current structure, right? If that's the case, I would suggest tackling this in two steps, the first entirely removing the Abi definition from edit: it's worth mentioning that I will follow your lead on this since you're more experienced with this part of the code Niraj, I am just making a suggestion, so feel free to ignore it :P |
@cbrzn We could have but I already finished 1/3 of the work |
perfect, go for it then bro |
…abi-from-schema-parse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 you rock Niraj - Thanks for pushing this forward
Co-authored-by: Cesar Brazon <cesarbrazon10@gmail.com>
envType: createEnvDefinition({ | ||
properties: [ | ||
createScalarPropertyDefinition({ name: "foo", type: "String", required: true }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbrzn can you please disable auto formatting, it bloats the size of PRs and makes it difficult to identify where changes have occurred that are not just styling changes.
@@ -22,7 +22,8 @@ | |||
"type": "string", | |||
"enum": [ | |||
"wasm", | |||
"interface" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes should technically be going into a new version of the schema. Since no breaking changes are being made (if I'm correct) the version would be 0.2
.
Since this work is fixing things that should have been done before origin release, we can slide these changes in unnoticed right now IMO, but this should be the last time we do something like this.
closes #973
Abi
from schema parse withWrapAbi
from wrap manifest.