-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: imported optional Map type bindings in Rust #1168
Conversation
nice catch ser 🙏, I previously fixed this but only in object types (#1142) and not for imported object types. I guess you also need to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Just need tests to go green
Thanks. 😄 |
Thanks! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krisbitney Is it also fixed for the methodTypes?
I fixed both the issues mentioned in the PR description. Are you referring to one of those or something else? |
Just checked it and we are good to go ser |
There are two issues affecting imported Map type bindings from compiling in Rust.
First
Second
In the object serialization logic for optional Map type, we are trying to pass a String instead of a Result<String, Error>. Example: