-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra Pipeline: Modular Environment Setups #328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dOrgJelli
previously approved these changes
Jun 7, 2022
dOrgJelli
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR aims to enable the new
infra
CLI command. This command would be used to provide a better, modular and extensible environment orchestration leveragingdocker-compose
. It also introduces the newinfra manifest
extension.The user would declare
modules
, which are packages that expose adocker-compose
YAML file. The CLI would fetch these packages, cache them, resolve thedocker-compose
YAML of each, and bundle them into a singledocker-compose project
.Additionally, the user can write a custom
docker-compose
file and declare additional services or custom functionality in case no modules suffice their needs. This customdocker-compose
is declared and gets bundled and orchestrated along with the rest of the modules.The CLI also provides some "preset" (or default) environments; which are already properly configured for typical/common use cases. If the user wishes to use one of these, his project's
infra manifest
gets ignored, and the preset's environment's gets used instead.The
infra
command has the following subcommands:up
: takes all modules and performs adocker-compose up
down
: same asdocker-compose down
config
: takes all modules, performs the bundling and outputs the bundleddocker-compose
project. Useful for validation and debugging.vars
: prints a list of all required environment variables needed across all bundled modulesAnd the following flags:
--modules
: acts as a filter of modules. Instead of bundling all modules declared in the infra manifest, it only bundles those specified in the flag.--preset
: ignores project's infra manifest and uses the selected preset's configuration.Additional changes
infra
pipeline, a preset was created to replace the current "test environment". It orchestrates ganache + ens + ipfs, and provides deterministically consistent and permanent ENS contract addresses. The ENS redeployment endpoint was removed from the DevServer. This package is maintained here.