http plugin: response header as a list #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray) instead of string. We need to handle it and convert to string
Niraj-Kamdar
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
LGTM!
But we should research on creating more robust request-response type, since as we can see in the case of set-cookie, we need to parse the key, value manually on wrapper side which can be tedious task and definitely be automated.
We can look into http libraries of different strongly typed languages like Rust, go, c++ to know how they are handling it.
nerfZael
approved these changes
Feb 21, 2022
dOrgJelli
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Axios could return value in response header as a list (array) instead of string. We need to handle it and convert it to string
Closes: #655