CLI deployment pipeline #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namesty
requested review from
dOrgJelli,
krisbitney and
nerfZael
as code owners
| "core: deserializeDeployManifest", | ||
| (manifest: string, options?: DeserializeManifestOptions): DeployManifest => { | ||
| let anyDeployManifest: AnyDeployManifest | undefined; | ||
| try { |
There was a problem hiding this comment.
Why don't we load json with yaml loader? Since YAML is superset of JSON, it should be possible.
Niraj-Kamdar
previously approved these changes
Apr 15, 2022
| @@ -948,7 +948,7 @@ describe("Web3ApiClient", () => { | |||
| ).toBe(true); | |||
| }); | |||
|
|
|||
| it("simple-storage", async () => { | |||
| it.only("simple-storage", async () => { | |||
There was a problem hiding this comment.
Is it debug leftover?
| fd.append(formDataEntry.key, elementData, options); | ||
| }); | ||
|
|
||
| const resp = await axios.post(`${ipfsUrl}/api/v0/add`, fd, { |
There was a problem hiding this comment.
Will it also pin or we need separate deployer for pinning?
dOrgJelli
previously approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #670.
This PR aims to create a modular deployment pipeline for Polywrap's CLI. It introduces a new
deployCLI command and aDeployManifest.Users declare deployment "stages" or steps, where each one performs deployment actions. Each stage takes a
Uriargument outputs aUri. Additionally, stages can be chained, so that the output of a stage can automatically be used as the input of another.This aims to provide a modular, extensible, way of performing complex deployment/publishing/persistance actions that may depend on each other. An example use case would be:
Each stage has an associated (declared) external package (wrappers in the future) that implements the
Deployerinterface:The CLI determines the dependency chains, executes each stage in order of dependency and properly passes the outputs/inputs from one stage to another.
Sometimes, stages (and its packages) need additional arguments in order to execute the deployment actions. For example, an ENS deployment stage may need an ethereum provider URL. These additional arguments are declared as part of the
configobject of each stage.Each package may provide a
web3api.deploy.ext.jsonmanifest extension file, with the necessary rules to validate theconfigproperties it needs. The CLI extracts these extensions, links them to the appropriate stage in the "base" manifest and performs manifest validation. If the extension does not exist, theconfigproperty of that stage is not validated.