-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client-js): add functionality to run workflows from client #878
Conversation
- implemented async cookbook runner was too naive to be used in real-life so I decided to just have sync cookbook runner to avoid confusions for the devs using async runner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 🔥
@@ -0,0 +1,87 @@ | |||
import { Workflow } from "@web3api/core-js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noob question: would it make sense to move this file to test-cases
package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to keep workflow test-cases separate from e2e test-cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This amazing :-)
I noticed that there's no need to add the cases
key, but it can be any other thing like tasks
, correct? The only thing is that it needs to be consistent with the other subjobs, meaning that you'd need to do task1
. Am I right on this ser? @Niraj-Kamdar
Not really @cbrzn, It can be any name. I just kept those names for the test-cases but you can have any kind job hierarchy. Ex: So, here, if there is. |
Linked Issues
Changelog
Next steps