-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Env refactor #967
Merged
Merged
Env refactor #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removal of ClientEnv + Sanitize - Reserve env arg
dOrgJelli
requested review from
dOrgJelli,
krisbitney and
nerfZael
as code owners
June 30, 2022 22:12
dOrgJelli
reviewed
Jun 30, 2022
dOrgJelli
approved these changes
Jul 1, 2022
Niraj-Kamdar
reviewed
Jul 1, 2022
Niraj-Kamdar
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR aims to change the way environment variables/configuration is passed to wrappers. This was done with 5 main objectives in mind:
ClientEnv
andsanitizeEnv
conceptOver the course of the development and discussion process, we realized there were additional tasks to implement to be feature complete. So this PR also enables:
Developer experience changes
We're introducing the
@env
directive, which annotates methods that use an environment configuration:schema.graphql:
Additionally, now module methods take a second
env
argument, from where the wrapper developer can access the environment variables:index.ts: