-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Build manifest refactor #986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der for toolchain manifest
…ap/monorepo into feat/build-structure-improvements
cbrzn
force-pushed
the
feat/build-structure-improvements
branch
from
July 1, 2022 17:17
62b8d56
to
ddb2985
Compare
…ng type in manifest
Package structure fixes
…ap/monorepo into feat/build-structure-improvements
Using local plugin package to test schema
…ap/monorepo into feat/build-structure-improvements
cbrzn
requested review from
dOrgJelli,
krisbitney,
namesty and
nerfZael
as code owners
July 5, 2022 12:37
dOrgJelli
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update the schema build artifact according to this document https://hackmd.io/@zbs1CidlRU6NAc7CvPR28w/S18Vk_X59
The
polywrap.json
has been removed from the build folder andwrap.info
has been added, this is a msgpack file that contains theWrapManifest
. Alsomodule.wasm
has been renamed towrap.wasm
The manifests structure has been refactored, now we have
polywrap
andwrap
manifest.polywrap
is the one related to the toolchain (build, deploy, infra, app) andwrap
refers to the WRAP protocol. A foldermanifest
inside ofpackages/js
with the generation scripts for thejson-schemas
The URI resolvers (IPFS & FS) has been updated to fetch the
wrap.info
fileValidation package has been updated accordingly with new build improvements
Changes
wrap.info
manifest@polywrap/wrap-manifest-schemas
+@polywrap/polyywrap-manifest-schemas
packages. These will have the script to generate the ts interfaces and now these files will live inside of each packagegetManifest
to returnWrapManifest
module.wasm
towrap.wasm
polywrap.meta
Future Refactors
schema.graphql
from the build artifactsgetSchema
import_redirects
to haveto: String
andfrom: Uri or Path