Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Build manifest refactor #986

Merged
merged 58 commits into from
Jul 6, 2022

Conversation

cbrzn
Copy link
Contributor

@cbrzn cbrzn commented Jun 28, 2022

This PR aims to update the schema build artifact according to this document https://hackmd.io/@zbs1CidlRU6NAc7CvPR28w/S18Vk_X59

The polywrap.json has been removed from the build folder and wrap.info has been added, this is a msgpack file that contains the WrapManifest. Also module.wasm has been renamed to wrap.wasm

The manifests structure has been refactored, now we have polywrap and wrap manifest. polywrap is the one related to the toolchain (build, deploy, infra, app) and wrap refers to the WRAP protocol. A folder manifest inside of packages/js with the generation scripts for the json-schemas

The URI resolvers (IPFS & FS) has been updated to fetch the wrap.info file

Validation package has been updated accordingly with new build improvements

Changes

  • Creating the wrap.info manifest
  • Creating @polywrap/wrap-manifest-schemas + @polywrap/polyywrap-manifest-schemas packages. These will have the script to generate the ts interfaces and now these files will live inside of each package
  • Refactored getManifest to return WrapManifest
  • Update validation project
  • Rename module.wasm to wrap.wasm
  • Remove all Polywrap manifests from the build artifacts EXCEPT polywrap.meta

Future Refactors

  • Update schema compose project to import ABIs and not schemas
  • Remove schema.graphql from the build artifacts
  • Removed getSchema
  • Plugin Typings
  • ArrayBuffer + ArrayBufferView usage (encoding issue fixes)
  • Core typing restructuring
  • Refactor import_redirects to have to: String and from: Uri or Path

cbrzn and others added 28 commits June 28, 2022 15:29
…ap/monorepo into feat/build-structure-improvements
@cbrzn cbrzn force-pushed the feat/build-structure-improvements branch from 62b8d56 to ddb2985 Compare July 1, 2022 17:17
@cbrzn cbrzn marked this pull request as ready for review July 5, 2022 12:37
@cbrzn cbrzn requested a review from Niraj-Kamdar July 5, 2022 12:53
@cbrzn cbrzn changed the title Feat/build structure improvements Feat: Build manifest refactor Jul 5, 2022
@dOrgJelli dOrgJelli merged commit 9ed762f into prealpha-dev Jul 6, 2022
@dOrgJelli dOrgJelli deleted the feat/build-structure-improvements branch April 10, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants