Deploy Manifest Refactor + Recursive ENS Registration Deployer #1097
Conversation
@Niraj-Kamdar I discussed this with Jure a week ago, and the conclusion was that when we'll make them wrappers in the near future (after wrapper embedding) and inevitably we'll need to tweak and make changes to the deploy command's workflow; but it shouldn't affect its usage as a user |
…-refactor # Conflicts: # packages/cli/src/__tests__/e2e/deploy.spec.ts # packages/cli/src/lib/defaults/deploy-modules/ens-recursive-name-register/index.ts # packages/js/manifests/polywrap/src/formats/polywrap.deploy/index.ts # packages/js/manifests/polywrap/src/formats/polywrap.deploy/validate.ts # packages/js/test-env/package.json # packages/js/test-env/src/index.ts
…-refactor # Conflicts: # packages/js/test-env/package.json
…ursive name registrar deployer
packages/js/manifests/polywrap/src/formats/polywrap.deploy/migrators/0.1.0_to_0.2.0.ts
Show resolved
Hide resolved
| export const embeddedWrappers = { | ||
| ens: `wrap://fs/${path.join(__dirname, "wrappers", "ens")}`, | ||
| uts46: `wrap://fs/${path.join(__dirname, "wrappers", "uts46")}`, | ||
| sha3: `wrap://fs/${path.join(__dirname, "wrappers", "sha3")}`, |
There was a problem hiding this comment.
Why do we need to embed uts46 & sha3?
There was a problem hiding this comment.
I think that the reason is that ENS wrapper needs those to work
There was a problem hiding this comment.
Tests sometimes fail to resolve the URIs and fetch the wrappers. It happens enough to make it hard to get all of the CI tests to pass at the same time. The ENS wrapper depends on the uts46 and sha3 wrappers now, so if we are embedding the ENS wrapper then it makes sense to embed uts46 and sha3 for the same reasons.
There was a problem hiding this comment.
Awesome work! Should be good to merged once @dOrgJelli 's comments are addressed.
Closes #1138