-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: map bindings for nested maps #1213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisbitney
requested review from
dOrgJelli,
nerfZael and
Niraj-Kamdar
as code owners
September 6, 2022 06:04
krisbitney
changed the title
Fix: map bindings for nested maps when imported, in envs, or in arrays
Fix: map bindings for nested maps
Sep 6, 2022
dOrgJelli
previously approved these changes
Sep 6, 2022
dOrgJelli
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The map bindings for nested maps were incorrectly trying to access map values within the
value
field of the ABI. However, the bindings are written to access themap
property. Themap
property exists at the same level of the object hierarchy as thevalue
property, not within it.This PR also fixes map key bindings for nested maps in assemblyscript (rust is already working correctly).
These fixes are tested by an update to the map-type wrapper test case.
Example ABI for nested generic map as return value from "simplePrice" method: