fix: interface module bindings #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niraj-Kamdar
requested review from
dOrgJelli,
krisbitney and
nerfZael
as code owners
Niraj-Kamdar
force-pushed
the
nk/fix-interface-module-bind
branch
from
437f3c1
to
a079c5d
Compare
cbrzn
reviewed
Sep 8, 2022
There was a problem hiding this comment.
Thanks for pushing this 🙏 Probably I am wrong and please correct me if so, but I think this adds the capability of interface invocation, hence, we should add the interface-invoke test cases (as in https://github.com/polywrap/toolchain/tree/origin/packages/test-cases/cases/wrappers/wasm-as/interface-invoke)
|
@cbrzn I agree, the tests should cover this scenario |
krisbitney
suggested changes
Sep 12, 2022
krisbitney
approved these changes
Sep 13, 2022
cbrzn
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust binding for interface-implementation invocation isn't working due to a bug in rust binding template checkout below issue for more details