Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: refactor Workflow tests and fix Workflow output #1234

Merged
merged 5 commits into from
Sep 17, 2022
Merged

Fix: refactor Workflow tests and fix Workflow output #1234

merged 5 commits into from
Sep 17, 2022

Conversation

krisbitney
Copy link
Contributor

@krisbitney krisbitney commented Sep 15, 2022 •
edited
Loading

In this PR:

  • Reworked and refactored Workflow test cases
  • Updated and adjusted Workflow tests; added new test
  • Fixed bug where Workflow validation always printed "SUCCESS" and errors were never printed
  • Fixed bug where Workflow manifest was not being validated
  • Fixed bug where the strong stderr messages were being output (previously unnoticed because errors were not printed)

@krisbitney
CLI run command test cases rework and refactor; fixed bug where valid…
d965fc9 
…ation always succeeds; fixed bug where workflow manifest was not being validated
@krisbitney
Fixed bug where the wrong stderr messages were being output for Workf…
94cdc78 
…low validation errors
cbrzn
cbrzn reviewed Sep 15, 2022
View reviewed changes
Copy link
Contributor

@cbrzn cbrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 😄👏

@krisbitney krisbitney requested a review from cbrzn September 15, 2022 18:48
Niraj-Kamdar
Niraj-Kamdar approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Really appreciate these quality of life improvements

@Niraj-Kamdar
Copy link
Contributor

@krisbitney What's the status of issue #984 after this PR?

This was referenced Sep 17, 2022
Closed
Closed
@krisbitney krisbitney merged commit d8a943d into origin-dev Sep 17, 2022
@krisbitney krisbitney deleted the refactor-workflow-tests branch September 17, 2022 03:58
@krisbitney krisbitney mentioned this pull request Sep 17, 2022
Closed
@krisbitney
Copy link
Contributor Author

@krisbitney What's the status of issue #984 after this PR?

I moved it to Done

@dOrgJelli dOrgJelli mentioned this pull request Sep 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbrzn cbrzn cbrzn approved these changes

@Niraj-Kamdar Niraj-Kamdar Niraj-Kamdar approved these changes

@dOrgJelli dOrgJelli Awaiting requested review from dOrgJelli dOrgJelli is a code owner

@namesty namesty Awaiting requested review from namesty namesty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krisbitney @Niraj-Kamdar @cbrzn