Wasm wrapper fixes and tests #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerfZael
changed the title
nerfZael
requested review from
dOrgJelli,
krisbitney and
namesty
as code owners
nerfZael
changed the title
nerfZael
changed the title
krisbitney
previously approved these changes
Sep 30, 2022
| | GetManifestOptions, | ||
| fileReaderOrManifestOptions?: IFileReader | GetManifestOptions, | ||
| manifestOptions?: GetManifestOptions | ||
| ): Promise<WasmWrapper> { |
There was a problem hiding this comment.
Should this return a Result?
There was a problem hiding this comment.
Yah I think we should start propagating errors instead of throwing.
There was a problem hiding this comment.
This method is intended to be used (and be very ergonomic) when the developer knows it will not fail (or doesn't care) because he's using compiled wrapper binaries (manifest and wasm module buffers).
E.g.
const client = new PolywrapClient({
resolver: RecursiveResolver.from([
...,
{ uri: "some-uri", wrapper: await WasmWrapper.from(manifestBuffer, wamModule) }
])
});If the developer wants a safe version (that returs Result) he can use WasmPackage.from().createWrapper() which is less ergonomic but gets the job done :)
dOrgJelli
requested changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.