Maybe async refactor #1287
Merged
Maybe async refactor #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 0916400 into b95c714 - view on LGTM.com fixed alerts:
|
nerfZael
requested review from
dOrgJelli,
krisbitney and
namesty
as code owners
pileks
approved these changes
Sep 28, 2022
dOrgJelli
approved these changes
Sep 30, 2022
| @@ -1,18 +1 @@ | |||
| export type MaybeAsync<T> = Promise<T> | T; | |||
There was a problem hiding this comment.
oh wow, had no clue you could await a non-async function and it'd return just fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.