Remove app & plugin project manifest default filenames #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, add warning for filename depreciation
dOrgJelli
previously approved these changes
Oct 6, 2022
|
This pull request introduces 1 alert when merging 43c0757 into a1a45c5 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1295
After this is merged,
polywrap.app.yamlandpolywrap.plugin.yamlwill still be silently accepted as default values for project manifest filenames, but a warning will be printed to the user notifying them of their impeding removal.Help texts shouldn't display them as default filenames anymore.
Remaining work:
docgen.tsstill has references)