Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix CLI hanging behavior #1316

Merged
merged 4 commits into from
Oct 11, 2022
Merged

Hotfix CLI hanging behavior #1316

merged 4 commits into from
Oct 11, 2022

Conversation

pileks
Copy link
Contributor

@pileks pileks commented Oct 10, 2022

After the removal of our spinner, if a CLI command didn't explicitly call process.exit(), I have encountered a behavior where the CLI would just hang (simply not exit) after it completed the command.

This PR fixes this behaviour, and should probably be hotfixed into the latest release of Polywrap, as it's a behavior reproducible on 0.9.0.

To reproduce the faulty behavior, polywrap create the wasm-as template with the current 0.9.0 release of Polywrap, and then try either polywrap codegen or polywrap build.

@pileks pileks requested review from nerfZael and cbrzn October 10, 2022 22:27
@pileks pileks changed the base branch from origin to origin-dev October 11, 2022 07:13
@dOrgJelli
Copy link
Contributor

Hmmmm, while I agree with the problem that needs to be fixed, the CI seems to have been "nuked" 😆 @pileks would you mind looking into why this is?

@cbrzn
Copy link
Contributor

cbrzn commented Oct 11, 2022

huh - interesting error, wonder how this slipped to origin

@pileks
Copy link
Contributor Author

pileks commented Oct 11, 2022

@dOrgJelli @cbrzn I see that you guys have re-run the CI and everything went smoothly (apart from the Test-Cli part). I ran the test on 2 machines - my PC and a VM which I use from my iPad and both seem to have worked fine. It does seem like it was something temporary in nature?

@pileks
Copy link
Contributor Author

pileks commented Oct 11, 2022

Disregard previous comment, I was running build instead of test locally. I can confirm that the create command has some wonky behavior and isn't exiting properly. Discussed this with @cbrzn and he is preparing a fix.

@dOrgJelli dOrgJelli merged commit 299003a into origin-dev Oct 11, 2022
@dOrgJelli dOrgJelli deleted the pileks/hotfix-cli-hanging branch April 10, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants