fix: proper view method result parsing #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerfZael
reviewed
Oct 12, 2022
| objects.push(element.toString()); | ||
| return prepared; | ||
| } else if ( | ||
| typeof value === "object" && |
There was a problem hiding this comment.
What are some examples where this is useful?
There was a problem hiding this comment.
This is necessary because ethers.js utilizes the BigNumber object to represent numbers larger than JS' number range (ex: uint256). When you simply JSON.stringify(...) a BigNumber the result is not desirable and just shows the internals of the object. This is because BigNumber does not implement a toJSON() method. So instead, we leverage object's toString() method if it's available.
nerfZael
previously approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/gelatodigital/polywrap-resolver/issues/9