Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: In Rust bindings, enum imports are now added in serialization modules when the enum is a subtype of an array (Vec) or map #1337

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Fix: In Rust bindings, enum imports are now added in serialization modules when the enum is a subtype of an array (Vec) or map #1337

merged 3 commits into from
Oct 18, 2022

Conversation

krisbitney
Copy link
Contributor

Enum imports are now added in serialization modules when the enum is a subtype of an array (Vec) or map

Closes #1313

@krisbitney krisbitney linked an issue Oct 17, 2022 that may be closed by this pull request
Rust bindings do not output import statements for enums when expected #1313
Closed
@krisbitney krisbitney changed the title Fix: import statements in Rust bindings are now added for enums when the enum is a subtype of a generic type Fix: In Rust bindings, enum imports are now added in serialization modules when the enum is a subtype of a vec or map Oct 17, 2022
@krisbitney krisbitney changed the title Fix: In Rust bindings, enum imports are now added in serialization modules when the enum is a subtype of a vec or map Fix: In Rust bindings, enum imports are now added in serialization modules when the enum is a subtype of an array (Vec) or map Oct 17, 2022
@dOrgJelli dOrgJelli merged commit 18fe384 into origin-dev Oct 18, 2022
@dOrgJelli dOrgJelli mentioned this pull request Oct 20, 2022
Merged
@dOrgJelli dOrgJelli deleted the rust-bindings-enum-imports branch April 10, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dOrgJelli dOrgJelli dOrgJelli approved these changes

@nerfZael nerfZael Awaiting requested review from nerfZael

@Niraj-Kamdar Niraj-Kamdar Awaiting requested review from Niraj-Kamdar

@namesty namesty Awaiting requested review from namesty namesty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust bindings do not output import statements for enums when expected
2 participants
@krisbitney @dOrgJelli