Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update CLI message with getCustomConfig #1368

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Fix: Update CLI message with getCustomConfig #1368

merged 1 commit into from
Oct 28, 2022

Conversation

cbrzn
Copy link
Contributor

@cbrzn cbrzn commented Oct 28, 2022 •
edited
Loading

With latest changes, when passing a custom client to the CLI, it expects that the JS/TS files exports getCustomConfig function instead of getClientConfig (Check here).

This PR aims to show the correct message when the user doesn't define this function

@cbrzn cbrzn requested review from pileks and nerfZael October 28, 2022 10:54
@dOrgJelli dOrgJelli merged commit 71c035b into origin-0.10-dev Oct 28, 2022
@dOrgJelli dOrgJelli mentioned this pull request Nov 5, 2022
Merged
@dOrgJelli dOrgJelli mentioned this pull request Nov 12, 2022
Merged
@dOrgJelli dOrgJelli deleted the fix/custom-client-cli-message branch April 10, 2023 17:02
@dOrgJelli dOrgJelli mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dOrgJelli dOrgJelli dOrgJelli approved these changes

@namesty namesty Awaiting requested review from namesty namesty is a code owner

@pileks pileks Awaiting requested review from pileks

@nerfZael nerfZael Awaiting requested review from nerfZael

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbrzn @dOrgJelli