[0.10] - Add logging to migration actions #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pileks
requested review from
dOrgJelli,
namesty,
nerfZael and
Niraj-Kamdar
as code owners
dOrgJelli
reviewed
Nov 2, 2022
| @@ -46,8 +46,11 @@ export function deserializePolywrapWorkflow( | |||
| ); | |||
|
|
|||
| if (versionCompare === -1) { | |||
| // Warn user to migrate their manifest | |||
| options?.logger?.warn(`PolywrapWorkflow is using an older version of the manifest format (${anyPolywrapWorkflow.format}). Please update your manifest to the latest version (${latestPolywrapWorkflowFormat}) by using the "polywrap manifest migrate <type>" command.`); | |||
There was a problem hiding this comment.
This looks fine to me, but just want to call out that we're making an explicit reference here to the Polywrap CLI, which is an external dependency to this package.
dOrgJelli
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
@polywrap/logging-jspackage which currently contains the types/interfaces required for packages other than the CLI to interact with logging.This introduces one caveat -
intlMsgcurrently only works on the CLI level.I'd like to open some discussion as to how we'd want to handle intl in the case where we really do go forward with logging being used in multiple packages.