feat: remove wasm-interface-types custom section #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dOrgJelli
changed the title
dOrgJelli
requested review from
krisbitney,
nerfZael and
cbrzn
as code owners
|
@dOrgJelli The new solution you suggested is working fine on Python client |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: polywrap/python-client#39, #1420
The
wasm-interface-typescustom section was "left over" after wasm-bindgen was run on the module. See issue #1420 for more details.NOTE: We need to publish the
polywrap/vm-base-rsimage to Docker Hub, pinged @namesty for access. Do not merge this PR before that is complete.