Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasm-as): codegen should create IModule interface #1460

Merged
merged 47 commits into from
Mar 8, 2023

Conversation

Niraj-Kamdar
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar commented Dec 20, 2022

Changelog

Features

  • Codegen for wasm wrappers now generates ModuleBase class that can be extended by wrap dev

Future work

This PR only changes devx for wrapper development for the Assemblyscript wrapper. Rust wrapper will be covered in the following PR #1464

Copy link
Contributor

@dOrgJelli dOrgJelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Added a few improvements I think could help.

@Niraj-Kamdar Niraj-Kamdar changed the title feat: allow developers to export a class that extends a base Module class found in after codegen feat(wasm-as): codegen should create IModule interface Dec 22, 2022
@Niraj-Kamdar Niraj-Kamdar marked this pull request as ready for review December 22, 2022 20:59
@Niraj-Kamdar
Copy link
Contributor Author

@cbrzn sorry for overwriting your commits. I got some git issues and wasn't able to fix it without force pushing.

Copy link
Contributor

@dOrgJelli dOrgJelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very eager to get these changes merged, it looks amazing.

I want to make sure we give users a seamless experience and options to go back to the legacy codegen if desired: https://github.com/polywrap/toolchain/blob/dorgjelli/binding-import/vision.md

@dOrgJelli
Copy link
Contributor

I suppose

I'm very eager to get these changes merged, it looks amazing.

I want to make sure we give users a seamless experience and options to go back to the legacy codegen if desired: https://github.com/polywrap/toolchain/blob/dorgjelli/binding-import/vision.md

I suppose we could do this "legacy support" and the decoupling of the binding projects from the toolchain repo in another PR right after this one, thoughts @Niraj-Kamdar?

@Niraj-Kamdar
Copy link
Contributor Author

https://github.com/polywrap/toolchain/blob/dorgjelli/binding-import/vision.md

It makes sense to me! And yes separate PR would be better. I don't want to make this one more monstrous than it already is!

dOrgJelli
dOrgJelli previously approved these changes Mar 7, 2023
@dOrgJelli dOrgJelli merged commit 3cca9b2 into origin-dev Mar 8, 2023
@dOrgJelli dOrgJelli deleted the nk/module-class-wasm branch April 10, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasm-as wrapper developers extend & implement IModule interface from wrap codegen
5 participants