-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wasm-as): codegen should create IModule interface #1460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Added a few improvements I think could help.
packages/test-cases/cases/bind/sanity/output/wasm-as/Module/module.ts
Outdated
Show resolved
Hide resolved
packages/test-cases/cases/bind/sanity/output/wasm-as/Module/module.ts
Outdated
Show resolved
Hide resolved
79dc068
to
ad7662c
Compare
@cbrzn sorry for overwriting your commits. I got some git issues and wasn't able to fix it without force pushing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very eager to get these changes merged, it looks amazing.
I want to make sure we give users a seamless experience and options to go back to the legacy codegen if desired: https://github.com/polywrap/toolchain/blob/dorgjelli/binding-import/vision.md
I suppose
I suppose we could do this "legacy support" and the decoupling of the binding projects from the toolchain repo in another PR right after this one, thoughts @Niraj-Kamdar? |
It makes sense to me! And yes separate PR would be better. I don't want to make this one more monstrous than it already is! |
Changelog
Features
Future work
This PR only changes devx for wrapper development for the Assemblyscript wrapper. Rust wrapper will be covered in the following PR #1464