fix: handle null return values from uri resolver extensions #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dOrgJelli
requested review from
nerfZael,
krisbitney and
namesty
as code owners
krisbitney
approved these changes
Jan 18, 2023
Thanks! This is a much-needed fix. I actually made a similar change in the PR that adds the ethereum wrapper. I think the text records issue I experienced was caused by me trying to resolve the ethereum wrapper from an ENS text record ENS resolution depends on the ethereum wrapper, so it was never going to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@krisbitney this actually helps debug the issue where the ENS text records were not resolving correctly. I'm working on getting that fixed right now, and came across this, as it was masking the problem occurring a few invocation layers deep.