Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update concurrent plugin interface uri #1496

Merged
merged 2 commits into from
Feb 1, 2023
Merged

update concurrent plugin interface uri #1496

merged 2 commits into from
Feb 1, 2023

Conversation

krisbitney
Copy link
Contributor

This PR updates the concurrent plugin to use an ENS text record URI

cbrzn
cbrzn approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@cbrzn cbrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! should we also update the wrappers that are in goerli to a text record in mainnet? following the same pattern as interfaces?

@krisbitney
Copy link
Contributor Author

cool! should we also update the wrappers that are in goerli to a text record in mainnet? following the same pattern as interfaces?

Yeah, for sure. I'll do it in another PR.

@dOrgJelli dOrgJelli merged commit ea8a523 into origin-dev Feb 1, 2023
@dOrgJelli dOrgJelli deleted the update-concurrent-plugin branch April 10, 2023 16:58
@dOrgJelli dOrgJelli mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbrzn cbrzn cbrzn approved these changes

@dOrgJelli dOrgJelli dOrgJelli approved these changes

@pileks pileks Awaiting requested review from pileks

@nerfZael nerfZael Awaiting requested review from nerfZael

@namesty namesty Awaiting requested review from namesty namesty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krisbitney @dOrgJelli @cbrzn