cli/create: remove node & react from supported langs in app template #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…langs in app template
cbrzn
changed the title
krisbitney
suggested changes
Feb 8, 2023
|
Maybe the PR is fine as is and we should merge it assuming it will work when 0.10.0 is released. We can do a patch fix if there are problems. What do you think? |
@krisbitney yes, that's the exact reason - actually, it amazes me that the CI went green (I was expecting it to fail lol). but yah, I feel comfortable with merging this so we're ready for 0.10 release |
krisbitney
approved these changes
Feb 9, 2023
dOrgJelli
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a previous PR the
typescript-nodeandtypescript-reacttemplates have been removed fromapp(#1500); this aims to update the create command with these changes.the ci did not catch this because we're directly downloading the latest version from npm (0.9.4) when running the create command. this makes me think that decoupling templates from toolchain might be a necessary thing to do sooner than later (so these things don't go to production without us noticing)