Removal of test env js #1530
Merged
Removal of test env js #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dOrgJelli
requested review from
nerfZael,
dOrgJelli,
krisbitney,
namesty and
Niraj-Kamdar
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1472
the package
@polywrap/test-env-jshas been completely removed from all the packages, except the CLI, being the reason that it has the embedded ENS wrapper and this is currently used by the ENS deploy module. After talking with @krisbitney he told me that after the PR #1446 is merged it would be possible to remove it (please Kris, if this is wrong feel free to let me know and I can update this comment)another thing worth mentioning is that the exported provider constants that were in the
test-env-jspackage now has been moved to the definition of the deploy module itself, and the packagecli-jsis reexporting those from the CLIas last, I would like to mention that currently in the plugin's readmes, we're showing how to deploy a wrapper and use those with it, I think that we should not show how to deploy those, but rather just how to interact with the plugins with already existing wrappers. would like to know your thoughts on this
open to any feedback