Fix: WrapError now correctly parsing Rust unwrap errors #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisbitney
requested review from
dOrgJelli,
namesty,
nerfZael,
cbrzn and
Niraj-Kamdar
as code owners
krisbitney
changed the title
dOrgJelli
approved these changes
Feb 16, 2023
|
Great catch @krisbitney, should this also be a patch for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
.unwrap()on a Rust result that contains an error, Rust will panic with an error message that contains theErr. For fidelity to the originalErr, Rust inserts escape characters in the string. For example,"\n"becomes"\\n". This behavior was not being handled correctly byWrapError's string parsing logic.