Add primaryJob to deploy manifest and output URI.txt when running polywrap deploy
#1592
Conversation
krisbitney
requested review from
dOrgJelli,
cbrzn,
namesty,
nerfZael,
pileks and
Niraj-Kamdar
as code owners
There was a problem hiding this comment.
Overall looks good! I’d love to see the platform dropped from the docker compose file as it was causing issues for me.
One thing to note - Instead of having the deploy output text file be in the same folder as the deploy manifest, we should have a deployments folder inside the .polywrap folder, with each deployment output being recorded in a datetime-named file, similar to how we export logs using the -l, --log-file option.
Also, it would be prudent to let the user know that a file has been output by logging something in the lines of “The output of the primary job has been logged into “./polywrap/deploys/primary-job-20230301122234.txt” or however we name them.
We’d have historic logs inside a folder that can be safely deleted and is gitignored by default, which could prove useful in the future.
packages/js/manifests/polywrap/src/formats/polywrap.deploy/0.3.0.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/defaults/infra-modules/eth-ens-ipfs/docker-compose.yaml
Outdated
Show resolved
Hide resolved
I like the idea of keeping a historic log. The deployment file should ideally be in the root of the repo. The reason for adding is so that it can be retrieved by a URI resolver extension wrapper. That way users can import a wrapper from a URI like |
|
To elaborate, we want people to commit the |
… log; internationalized strings
|
I added a historical deployment log stored at |
packages/js/client-config-builder/src/bundles/getDefaultConfig.ts
Outdated
Show resolved
Hide resolved
…-uri # Conflicts: # packages/js/client-config-builder/README.md # packages/js/client-config-builder/src/bundles/getDefaultConfig.ts
…r through getter method; renamed 'polywrap.deployment.txt' to 'URI.txt'
dOrgJelli
changed the title
primaryJob to deploy manifest and output polywrap.deployment.txt when running polywrap deployprimaryJob to deploy manifest and output URI.txt when running polywrap deploy
This PR adds a new option to the deploy manifest,
primaryJob. The option identifies the name of the job that is used for the primary deployment. The URI of the final step of the primary job is printed topolywrap.deployment.txt, which is output to the folder that contains the deploy manifest.The primary deployment URI is also recorded in a historical log, with a timestamp, located at the
.polywrap/deploy/deploy.log.This PR enables the UX described in polywrap/uri-resolver-extensions#19