-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client config - unique maps #1613
Merged
dOrgJelli
merged 26 commits into
origin-dev
from
pileks/feat/js-client-config-unique-maps
Mar 16, 2023
Merged
Client config - unique maps #1613
dOrgJelli
merged 26 commits into
origin-dev
from
pileks/feat/js-client-config-unique-maps
Mar 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-client-config-unique-maps
…2.0' into pileks/feat/js-client-config-unique-maps
…client-config-unique-maps
…client-config-unique-maps
…s-client-config-unique-maps
…client-config-unique-maps
…client-config-unique-maps
…client-config-unique-maps
pileks
requested review from
nerfZael,
dOrgJelli,
krisbitney and
namesty
as code owners
March 8, 2023 16:43
Niraj-Kamdar
previously approved these changes
Mar 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good improvement over existing list of objects structure!
…client-config-unique-maps
dOrgJelli
previously approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1283
This PR aims to change the
envs
andinterfaces
collections insideCoreClientConfig
into readonly unique maps/map-like structures.It achieves this by introducing the concept of
UriMap
s:envs
is now essentially:interfaces
is now essentially:Everything that can be is marked as
readonly
in order to relay the intended readonly nature of the CoreClientConfig.All of this boils down to the fact that the way we instantiate a new
CoreClientConfig
now looks like this: